Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primary key for ratelimit table #30235

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Add primary key for ratelimit table #30235

merged 2 commits into from
Feb 2, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Dec 13, 2021
@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Dec 13, 2021
@nickvergessen nickvergessen requested review from PVince81, LukasReschke, CarlSchwan, a team and ArtificialOwl and removed request for a team December 13, 2021 08:29
@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

/backport to stable22

@nickvergessen
Copy link
Member Author

/backport to stable21

@nickvergessen nickvergessen force-pushed the bugfix/noid/primary-key-for-ratelimit-table branch from 3c59e55 to 82efea6 Compare December 13, 2021 09:04
PVince81
PVince81 reviewed Dec 13, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@nickvergessen nickvergessen force-pushed the bugfix/noid/primary-key-for-ratelimit-table branch from 82efea6 to 1c1902f Compare December 13, 2021 11:24
@nickvergessen nickvergessen mentioned this pull request Dec 13, 2021
Closed
@nickvergessen nickvergessen force-pushed the bugfix/noid/primary-key-for-ratelimit-table branch from 1c1902f to cfb076b Compare January 10, 2022 12:11
GretaD
GretaD approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with my basic knowledge on php i think its fine, but somebody more experienced should double check

@solracsf solracsf linked an issue Jan 10, 2022 that may be closed by this pull request
Table oc_ratelimit_entries is missing a primary key #30562
Closed
@nickvergessen nickvergessen force-pushed the bugfix/noid/primary-key-for-ratelimit-table branch from cfb076b to 521158b Compare January 14, 2022 10:16
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2022
@nickvergessen
Add a primary key to ratelimit_entries table
fcb3e9a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make the DB query simpler (as we just deleted all other entries)
b59df35 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/primary-key-for-ratelimit-table branch from 521158b to b59df35 Compare January 28, 2022 15:55
@nickvergessen
Copy link
Member Author

Conflicting files
lib/composer/composer/autoload_classmap.php
lib/composer/composer/autoload_static.php

Rebased

@nickvergessen nickvergessen merged commit 5e5c31e into master Feb 2, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/primary-key-for-ratelimit-table branch February 2, 2022 09:03
This was referenced Feb 2, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@miaulalala miaulalala miaulalala left review comments

@GretaD GretaD GretaD approved these changes

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@PVince81 PVince81 Awaiting requested review from PVince81

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Table oc_ratelimit_entries is missing a primary key
5 participants
@nickvergessen @PVince81 @miaulalala @GretaD @CarlSchwan