Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Add primary key for ratelimit table #30965

Merged
merged 4 commits into from
Mar 10, 2022
Merged

[stable23] Add primary key for ratelimit table #30965

merged 4 commits into from
Mar 10, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 2, 2022 •
edited by nickvergessen
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #30235

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.1 milestone Feb 2, 2022
@nickvergessen
Copy link
Member

nickvergessen commented Feb 2, 2022 •
edited
Loading

  • Needs a version bump once stable is unblocked

@MichaIng MichaIng added the 2. developing Work in progress label Feb 3, 2022
@blizzz blizzz mentioned this pull request Feb 11, 2022
Merged
11 tasks
@blizzz blizzz mentioned this pull request Mar 9, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Mar 10, 2022

@nickvergessen what's the state here?

@nickvergessen
Add a primary key to ratelimit_entries table
17f32ca 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make the DB query simpler (as we just deleted all other entries)
e527a2a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update autoloader
24af964 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Bump version
7a8f704 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2022
@nickvergessen
Copy link
Member

Ready to review

@blizzz blizzz removed the 3. to review Waiting for reviews label Mar 10, 2022
@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 10, 2022
@PVince81 PVince81 merged commit 64f2bd1 into stable23 Mar 10, 2022
@PVince81 PVince81 deleted the backport/30235/stable23 branch March 10, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@miaulalala miaulalala Awaiting requested review from miaulalala

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 23.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @blizzz @CarlSchwan @PVince81 @MichaIng