Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tags and share component #32012

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Cleanup tags and share component #32012

merged 1 commit into from
Sep 29, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Apr 19, 2022 •
edited
Loading

  • Port to LoggerInterface
  • Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
  • Use IEventListener instead of hooks

Todos:

  • Finish IQueryBuilder port
  • Remove OC_DB as this is the only thing that still uses that
  • Testing

@CarlSchwan CarlSchwan added the 2. developing Work in progress label Apr 19, 2022
@CarlSchwan CarlSchwan self-assigned this Apr 19, 2022
@CarlSchwan CarlSchwan marked this pull request as draft April 19, 2022 11:07
@CarlSchwan CarlSchwan changed the title Cleanup tags component Cleanup tags and share component Apr 19, 2022
@CarlSchwan CarlSchwan force-pushed the cleanup/tags branch 2 times, most recently from 2af04fb to 21dd491 Compare April 19, 2022 17:05
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 19, 2022
@CarlSchwan CarlSchwan marked this pull request as ready for review April 19, 2022 17:08
@CarlSchwan CarlSchwan force-pushed the cleanup/tags branch 2 times, most recently from 31c03d6 to 1dcadb7 Compare April 19, 2022 20:27
nickvergessen
nickvergessen reviewed Apr 19, 2022
View reviewed changes
core/Application.php Outdated Show resolved Hide resolved
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@CarlSchwan CarlSchwan mentioned this pull request Apr 25, 2022
Open
15 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2022
View reviewed changes
lib/private/Share/Share.php Fixed Show fixed Hide fixed
lib/private/Share/Share.php Fixed Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Aug 8, 2022
View reviewed changes
lib/private/Tags.php Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Aug 8, 2022
View reviewed changes
lib/private/Tags.php Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Aug 8, 2022
View reviewed changes
lib/private/Tags.php Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Aug 8, 2022
View reviewed changes
lib/private/Tags.php Outdated Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@CarlSchwan CarlSchwan force-pushed the cleanup/tags branch 6 times, most recently from cc53a3f to dcc1a5a Compare September 19, 2022 13:27
@CarlSchwan
Copy link
Member Author

CI is now green :)

@CarlSchwan CarlSchwan force-pushed the cleanup/tags branch 3 times, most recently from b2b3286 to 960b90f Compare September 19, 2022 14:02
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@come-nc
Copy link
Contributor

come-nc commented Sep 29, 2022

/rebase

@come-nc come-nc self-assigned this Sep 29, 2022
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 29, 2022
@CarlSchwan @come-nc
Cleanup tags and Share component
92a5a8f 
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@come-nc come-nc merged commit fba6f25 into master Sep 29, 2022
@come-nc come-nc deleted the cleanup/tags branch September 29, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@CarlSchwan CarlSchwan

@come-nc come-nc

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@CarlSchwan @come-nc @nickvergessen @ChristophWurst @artonge @blizzz