Add plsam taint analysis baseline #33779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
come-nc
reviewed
Sep 1, 2022
Merged
come-nc
approved these changes
Oct 20, 2022
And remove some false positive Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
psalm-taint-escape
branch
from
a6734be to
0ae896b
Compare
miaulalala
approved these changes
Oct 20, 2022
| @@ -56,6 +56,7 @@ public function __construct( | |||
| * @return JSONResponse | |||
| */ | |||
| public function create(string $layout): JSONResponse { | |||
| $layout = htmlspecialchars($layout); | |||
There was a problem hiding this comment.
Maybe mention this in your commit message? 😅
|
Assigning that to me, the taint analysis is already done in an other job, but the docblock and escaping fixes from this PR should still be merged. |
4 tasks
Merged
Merged
Merged
|
conflicts :/ |
szaimen
added
2. developing
|
Replaced by #36378 for the relevant parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove some false positive