Add missing taint analysis docblock comments, and improve escaping in… #36378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5,007 new alerts including 48 errors Which is better than master: 5,012 new alerts including 53 errors But still, I would like to see those numbers lower. |
|
Just create a new baseline for now? |
|
/rebase |
nextcloud-command
force-pushed
the
fix/improve-taint-analysis
branch
from
360c837 to
de92baf
Compare
… some methods Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/improve-taint-analysis
branch
from
de92baf to
b1ec7ff
Compare
|
Removed the part in Good to merge. |
come-nc
added
3. to review
come-nc
requested review from
nickvergessen,
ChristophWurst,
juliusknorr and
szaimen
ChristophWurst
approved these changes
Apr 24, 2023
nickvergessen
approved these changes
Apr 25, 2023
juliusknorr
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Imported changes from #33779 that should fix some of the detected psalm taint errors.
Then we can see if we need a baseline or not.
Checklist