Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docblock for cacheFor #33889

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Update docblock for cacheFor #33889

merged 2 commits into from
Sep 5, 2022

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 3, 2022 

ERROR: TooManyArguments - lib/Controller/AvatarsController.php:85:14 - Too many arguments for method OCP\AppFramework\Http\Response::cachefor - saw 3 (see https://psalm.dev/026)
                $response->cacheFor(7 * 24 * 60 * 60, false, true);

Psalm sometimes complains about the outdated docblock.

@kesselb
Update docblock for cacheFor
855ef21 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb self-assigned this Sep 3, 2022
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 3, 2022
@kesselb kesselb added this to the Nextcloud 25 milestone Sep 3, 2022
CarlSchwan
CarlSchwan reviewed Sep 3, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more comments 😜

lib/public/AppFramework/Http/Response.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Http/Response.php Outdated Show resolved Hide resolved
@kesselb @CarlSchwan
Add description for public and immutable
c55ae98 
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Daniel <mail@danielkesselberg.de>
@kesselb
Copy link
Contributor Author

kesselb commented Sep 3, 2022

image

Lucky me ;)

@kesselb kesselb requested review from a team, ArtificialOwl and icewind1991 and removed request for a team September 5, 2022 08:35
@CarlSchwan CarlSchwan requested a review from szaimen September 5, 2022 15:10
@kesselb kesselb merged commit 8de2c42 into master Sep 5, 2022
@kesselb kesselb deleted the debt/noid/docblock-cache-for branch September 5, 2022 15:21
@blizzz blizzz mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @CarlSchwan @szaimen