Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docblock for cacheFor #33889

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Update docblock for cacheFor #33889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
855ef21
Update docblock for cacheFor
kesselb Sep 3, 2022
c55ae98
Add description for public and immutable
kesselb Sep 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/public/AppFramework/Http/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ public function __construct() {

/**
* Caches the response
* @param int $cacheSeconds the amount of seconds that should be cached
* if 0 then caching will be disabled
*
* @param int $cacheSeconds amount of seconds the response is fresh, 0 to disable cache.
* @param bool $public whether the page should be cached by public proxy. Usually should be false, unless this is a static resources.
* @param bool $immutable whether browser should treat the resource as immutable and not ask the server for each page load if the resource changed.
* @return $this
* @since 6.0.0 - return value was added in 7.0.0
*/
Expand Down