Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edit locally file action #34171

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Add edit locally file action #34171

merged 1 commit into from
Sep 21, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 20, 2022 •
edited
Loading

Close #33275

image

Based on https://github.com/nextcloud/desktop/blob/v3.6.0/doc/architecture.rst#local-file-editing

@jancborchardt @nimishavijay currently using the same icon as "Rename", any new icon suggestions?

@tobiasKaminsky @allexzander this was tested on the https://github.com/nextcloud/desktop/releases/tag/v3.6.0 client, let me know if any changes are needed

@Pytal
Add edit locally file action
d415c65 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 25 milestone Sep 20, 2022
@Pytal Pytal requested review from tobiasKaminsky, allexzander and a team September 20, 2022 19:53
@Pytal Pytal self-assigned this Sep 20, 2022
@Pytal Pytal requested review from PVince81, skjnldsv and szaimen and removed request for a team September 20, 2022 19:53
PVince81
PVince81 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested a review from CarlSchwan September 21, 2022 09:18
tobiasKaminsky
tobiasKaminsky approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@PVince81
Copy link
Member

I've restarted the Drone tests as there where some unexpected failures / env issues.

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 21, 2022
@karlitschek
Copy link
Member

I like 'Edit' more for the reasons @AndyScherzinger mentioned. 'Opening' sounds more like Downloading only.

@szaimen
Copy link
Contributor

szaimen commented Sep 21, 2022

CI failure unrelated

@szaimen szaimen merged commit 8268416 into master Sep 21, 2022
@szaimen szaimen deleted the enh/edit-locally branch September 21, 2022 12:11
@nimishavijay
Copy link
Member

any new icon suggestions?

How about the computer icon?

@jancborchardt

@Pytal Pytal mentioned this pull request Sep 21, 2022
Merged
@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@szaimen
Copy link
Contributor

szaimen commented Nov 25, 2022

Hello, I just found out that this option is also shown for folders. Is this expected or does it only work for files?

Also it seems like the option is not shown in the right-click menu.

Shall I open a new issue for this?

@AndyScherzinger
Copy link
Member

@szaimen yes, please 👍

@Pytal
Copy link
Member Author

Pytal commented Nov 26, 2022

Hello, I just found out that this option is also shown for folders. Is this expected or does it only work for files?

Folders would be opened in the file manager or whichever application the OS thinks is appropriate in my testing

@AndyScherzinger
Copy link
Member

Ah, then it is okay to keep it I think 👍

@szaimen szaimen mentioned this pull request Nov 29, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Nov 29, 2022

Also it seems like the option is not shown in the right-click menu.

created #35481

@Pytal Pytal mentioned this pull request Jan 4, 2023
Closed
4 tasks
@joshtrichards joshtrichards mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen left review comments

@AndyScherzinger AndyScherzinger AndyScherzinger left review comments

@jospoortvliet jospoortvliet jospoortvliet left review comments

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@PVince81 PVince81 PVince81 approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish client: 💻 desktop feature: files
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

"Edit locally" option
8 participants
@Pytal @PVince81 @karlitschek @szaimen @nimishavijay @AndyScherzinger @jospoortvliet @tobiasKaminsky