Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit locally action to not appear for folders #35999

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Jan 4, 2023

Extends FileActions to also allow the meta "files" mime type.

Checklist

Extends FileActions to also allow the meta "files" mime type.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added the 3. to review Waiting for reviews label Jan 4, 2023
@PVince81 PVince81 added this to the Nextcloud 26 milestone Jan 4, 2023
@PVince81 PVince81 self-assigned this Jan 4, 2023
@PVince81
Copy link
Member Author

PVince81 commented Jan 4, 2023

hold on, @Pytal just told me that having "Edit locally" for folders is intentional

it would make it possible to open a folder locally

should we keep it ? @jancborchardt

@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 4, 2023
@Pytal
Copy link
Member

Pytal commented Jan 4, 2023

hold on, @Pytal just told me that having "Edit locally" for folders is intentional

it would make it possible to open a folder locally

Yes, was discussed in the original PR #34171 (comment)

@PVince81
Copy link
Member Author

PVince81 commented Jan 5, 2023

now thinking, maybe the text should be "Open folder locally" to make it less confusing

@PVince81
Copy link
Member Author

it's not possible to dynamically change the text, so it would require a different approach / hack. closing for now

@PVince81 PVince81 closed this Jan 16, 2023
@skjnldsv skjnldsv deleted the bugfix/noid/fix-edit-locally-for-files-only branch March 14, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants