Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not import from axios but only @nextcloud/axios #45161

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 2, 2024

Summary

Do not import from axios this is extranous, but only from @nextcloud/axios.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels May 2, 2024
@susnux susnux added this to the Nextcloud 30 milestone May 2, 2024
@susnux susnux requested review from Fenn-CS and Pytal May 2, 2024 20:18
@susnux susnux requested a review from skjnldsv as a code owner May 2, 2024 20:18
apps/settings/src/utils/handlers.ts Outdated Show resolved Hide resolved
@susnux susnux force-pushed the fix/import-axios branch 4 times, most recently from 55fd721 to 65973d0 Compare May 6, 2024 18:18
@skjnldsv
Copy link
Member

Can you explain 65973d0 ? :)

@susnux
Copy link
Contributor Author

susnux commented May 15, 2024

Can you explain 65973d0 ? :)

See if CI gets green, because currently this is blocked (that commit is from #45207 ). Meaning we can not use latest @nextcloud/axios because webdav does not work with X-Requested-With: XMLHttpRequest.

CI looks good so dropped the commit again, but adjusted the target so we chain onto #45207

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 24, 2024
@susnux
Copy link
Contributor Author

susnux commented May 29, 2024

Still waiting for #45207

Base automatically changed from fix/webdav-aja to master June 20, 2024 10:28
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 8ac9e08 into master Jun 20, 2024
125 checks passed
@susnux susnux deleted the fix/import-axios branch June 20, 2024 13:06
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants