-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): Try basic auth for ajax WebDAV requests #45207
Conversation
The problem gets visible because previous versions of Meaning the alternative to this is to drop the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking temporarily
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Tested and concerned issue is not happening
/backport to stable29 |
Summary
Allow using basic auth with ajax requests on WebDAV.
The idea why the code was added in the first place was to ensure that if basic auth fails the user gets not asked by the browser for the correct credentials.
We still keep this behavior by throwing a 401 error in case of failed basic auth.
Checklist