Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setupChecks): Update Transactional File Locking instructions #45471

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 22, 2024

Summary

The filelocking.enabled toggle is no longer relevant today since TFL is now on by default and is no longer an experimental feature (hasn't been for nearly a decade). There is no good reason to disable it. The toggle only exists to be able to enable it, when it was still experimental. It's also been removed from the docs.

This PR:

  • makes the setup check firmer
  • enhances the instructions
  • changes from a warning to an error
  • renames check from "File Locking" -> "Transaction File Locking" for consistency with docs (and to distinguish from types)

Complements #45330 and nextcloud/documentation#11848 (does not depend on either)

TODO

Checklist

@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 22, 2024
@joshtrichards joshtrichards force-pushed the fix-setupcheck-filelocking branch 2 times, most recently from 4a145af to 4fdeae4 Compare May 28, 2024 15:14
@joshtrichards joshtrichards changed the title fix(setupChecks): Having transactional file locking disabled is not supported fix(setupChecks): Update Transactional File Locking instructions May 29, 2024

This comment was marked as resolved.

This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 6, 2024
…upported

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@icewind1991 icewind1991 merged commit 7307671 into master Sep 19, 2024
175 checks passed
@icewind1991 icewind1991 deleted the fix-setupcheck-filelocking branch September 19, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants