Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setupChecks): Update Transactional File Locking instructions #45471

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(setupChecks): Update Transactional File Locking instructions #45471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/settings/lib/SetupChecks/FileLocking.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct(
}

public function getName(): string {
return $this->l10n->t('File locking');
return $this->l10n->t('Transactional File Locking');
}

public function getCategory(): string {
Expand All @@ -43,8 +43,8 @@ protected function hasDBFileLocking(): bool {

public function run(): SetupResult {
if (!$this->hasWorkingFileLocking()) {
return SetupResult::warning(
$this->l10n->t('Transactional file locking is disabled, this might lead to issues with race conditions. Enable "filelocking.enabled" in config.php to avoid these problems.'),
return SetupResult::error(
$this->l10n->t('Transactional File Locking is disabled. This is not a a supported configuraton. It may lead to difficult to isolate problems including file corruption. Please remove the `\'filelocking.enabled\' => false` configuration entry from your `config.php` to avoid these problems.'),
$this->urlGenerator->linkToDocs('admin-transactional-locking')
);
}
Expand Down
Loading