Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated images for Material icons and added SPDX info #45706

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jun 7, 2024

  • Resolves: # further SPDX infos and M3 icon replacements aligned with Jan

Summary

  • files with copyright information: 10749 / 11030
  • files with license information: 10732 / 11030

TODO

  • review and merge

Checklist

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 7, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be weird 🙈
https://pictogrammers.com/library/mdi/icon/account-multiple/ and https://pictogrammers.com/library/mdi/icon/account-group/ look more similar than the pervious one.
Quite some usecases I found are all focusing on "multiple users" and less on "account" when using this icon 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can re-iterate a a follow up but would love to have @jancborchardt opinion on replacing it with another one.

@AndyScherzinger AndyScherzinger merged commit 3237123 into master Jun 7, 2024
104 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/spdx-batch15 branch June 7, 2024 12:40
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants