Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dist): Make sure changed icons are compiled #45712

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

nickvergessen
Copy link
Member

  • Regression from Updated images for Material icons and added SPDX info #45706 which only changed icons
  • it did not recompile the icons.css
  • but since no matching file was changed, the node.yml job didn't run there
  • Since then all PRs that do change a checked file fail with red CI without having changed the file.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 08baf17 into master Jun 7, 2024
157 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/commit-changed-icons branch June 7, 2024 16:12
@susnux
Copy link
Contributor

susnux commented Jul 3, 2024

Missing: core/css

Noticed on this PR, which was merged without compiled styles #46270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants