Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match input height with clickable area #46270

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

marcoambrosini
Copy link
Member

Brings it from hardcoded 36 px to current default (34px)

Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@marcoambrosini marcoambrosini requested review from susnux, ShGKme, a team, Pytal and sorbaugh and removed request for a team July 3, 2024 07:18
@marcoambrosini marcoambrosini self-assigned this Jul 3, 2024
@marcoambrosini marcoambrosini added this to the Nextcloud 30 milestone Jul 3, 2024
@marcoambrosini marcoambrosini changed the title feat: Match input height with clickable area Match input height with clickable area Jul 3, 2024
@marcoambrosini marcoambrosini mentioned this pull request Jul 3, 2024
28 tasks
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder is now too close to the bottom, don't forget to adjsut it

image

@marcoambrosini marcoambrosini merged commit 829d7a9 into master Jul 3, 2024
110 checks passed
@marcoambrosini marcoambrosini deleted the feat/match-input-height-with-clickable-area branch July 3, 2024 07:55
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants