Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dashboard panels border radius #46201

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update dashboard panels border radius #46201

merged 1 commit into from
Jul 3, 2024

Conversation

marcoambrosini
Copy link
Member

No description provided.

@marcoambrosini marcoambrosini self-assigned this Jun 29, 2024
@marcoambrosini marcoambrosini added this to the Nextcloud 30 milestone Jun 29, 2024
@marcoambrosini marcoambrosini mentioned this pull request Jun 29, 2024
Closed
28 tasks
@ShGKme
Copy link
Contributor

ShGKme commented Jun 29, 2024

Changes dashboard widgets to be the same as main container in apps:

Before After
image image

ShGKme
ShGKme approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also change the padding to be in line with border radius?

apps/dashboard/src/DashboardApp.vue
border-radius: var(--border-radius-rounded);
border-radius: var(--body-container-radius);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we should also add this variable to the theming.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this one already there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ShGKme means adding it to theming / the theme from the theming app

@susnux
Copy link
Contributor

susnux commented Jul 1, 2024

I wonder why this is not styled in the NcDashboardWidget 🤔

But you then also need to adjust all "guest-box" components (login etc) which we unified with the dashboard widgets not long ago

@marcoambrosini
Copy link
Member Author

I wonder why this is not styled in the NcDashboardWidget 🤔

I also thought I would find it there

But you then also need to adjust all "guest-box" components (login etc)

Could you please point me to the components @susnux?

@marcoambrosini
Copy link
Member Author

@susnux should we tackle this in separate prs so that we get the important stuff in?

@susnux susnux force-pushed the feat/update-dashboard-border-radius branch from 9b407ed to 6c48237 Compare July 2, 2024 19:39
@susnux
Copy link
Contributor

susnux commented Jul 2, 2024

/compile amend/

@susnux susnux enabled auto-merge July 2, 2024 19:40
@marcoambrosini @nextcloud-command
Feat: update panels border radius
479d394 
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the feat/update-dashboard-border-radius branch from 6c48237 to 479d394 Compare July 2, 2024 19:47
@susnux susnux mentioned this pull request Jul 2, 2024
Merged
4 tasks
@marcoambrosini marcoambrosini changed the title Feat: update panels border radius Update panels border radius Jul 3, 2024
@marcoambrosini marcoambrosini changed the title Update panels border radius Update dashboard panels border radius Jul 3, 2024
@susnux susnux merged commit 4a3f8a2 into master Jul 3, 2024
110 checks passed
@susnux susnux deleted the feat/update-dashboard-border-radius branch July 3, 2024 09:50
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoambrosini @ShGKme @susnux