feat(theming): Provide body-container- variables through theming
#46259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
marcoambrosini,
a team,
Fenn-CS,
Pytal,
sorbaugh and
artonge
and removed request for
a team and
Pytal
susnux
force-pushed
the
feat/provide-body-container
branch
from
ac54818
to
16d0c82
Compare
marcoambrosini
approved these changes
Jul 3, 2024
susnux
force-pushed
the
feat/provide-body-container
branch
from
16d0c82
to
6925876
Compare
skjnldsv
approved these changes
Jul 4, 2024
* Provide the body container height, radius and margin as theming variables. * Remove unused old variables (`header-menu-profile-item-height` and `list-max-width`) * Fix comment about breakpoint JS location Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/provide-body-container
branch
from
6925876
to
6ef88de
Compare
susnux
added a commit
to nextcloud/documentation
that referenced
this pull request
Jul 7, 2024
* For nextcloud/server#46259 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
header-menu-profile-item-heightandlist-max-width)I will create a documentation PR as soon as the ground work is merged ( nextcloud/documentation#11952 )
Checklist