Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DAV): offset not applied #46219

Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jul 1, 2024

Summary

with more than 100 results, this job may never finish

Question though: do we still need this job?

Checklist

with more than 100 results, this job may never finish

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug 3. to review Waiting for reviews labels Jul 1, 2024
@blizzz
Copy link
Member Author

blizzz commented Jul 1, 2024

/backport to stable29

@blizzz
Copy link
Member Author

blizzz commented Jul 1, 2024

/backport to stable28

conflicts, did manually

@blizzz blizzz changed the title fix(BuildSocialSearchIndexBackgroundJob): offset not applied fix(DAV): offset not applied Jul 1, 2024
@blizzz blizzz requested a review from max-nextcloud July 1, 2024 12:41
@@ -59,6 +60,7 @@
->from('cards', 'c')
->orderBy('id', 'ASC')
->where($query->expr()->like('carddata', $query->createNamedParameter('%SOCIALPROFILE%')))
->andWhere($query->expr()->gt('id', $query->createNamedParameter((int)$offset, IQueryBuilder::PARAM_INT)))

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType Note

Redundant cast to int given docblock-provided type
@blizzz blizzz merged commit 7bd2158 into master Jul 1, 2024
165 checks passed
@blizzz blizzz deleted the fix/noid/infinit-BuildSocialSearchIndexBackgroundJob branch July 1, 2024 16:37
@blizzz blizzz restored the fix/noid/infinit-BuildSocialSearchIndexBackgroundJob branch July 8, 2024 20:27
@blizzz blizzz deleted the fix/noid/infinit-BuildSocialSearchIndexBackgroundJob branch July 8, 2024 20:29
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants