Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(DAV): offset not applied #46226

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 1, 2024

Backport of PR #46219

with more than 100 results, this job may never finish

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Jul 1, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.4 milestone Jul 1, 2024
@@ -77,6 +78,7 @@
->from('cards', 'c')
->orderBy('id', 'ASC')
->where($query->expr()->like('carddata', $query->createNamedParameter('%SOCIALPROFILE%')))
->andWhere($query->expr()->gt('id', $query->createNamedParameter((int)$offset, IQueryBuilder::PARAM_INT)))

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType Note

Redundant cast to int given docblock-provided type
@blizzz blizzz requested a review from miaulalala July 4, 2024 12:18
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 4, 2024
@blizzz blizzz merged commit d4b5d63 into stable29 Jul 4, 2024
177 checks passed
@blizzz blizzz deleted the backport/46219/stable29 branch July 4, 2024 17:40
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants