-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add direct parameter to flow auth v2 #46534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/direct-flow-v2
branch
from
July 16, 2024 12:54
9715823
to
5907c00
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/direct-flow-v2
branch
from
August 5, 2024 10:13
5907c00
to
1aa2944
Compare
juliusknorr
requested review from
a team,
ArtificialOwl,
icewind1991,
yemkareems,
ChristophWurst and
Altahrim
and removed request for
a team,
ArtificialOwl,
icewind1991 and
yemkareems
August 5, 2024 10:14
susnux
approved these changes
Aug 5, 2024
ChristophWurst
approved these changes
Aug 5, 2024
/backport to stable29 |
/backport to stable28 |
This was referenced Aug 5, 2024
Merged
/backport to stable27 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SSO environments with environment variable like kerberos we may not have this authentication type on iOS devices. The current approach to still allow login is to use a direct login with configuring a rewrite on the webserver level:
Summary
Checklist