Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add direct parameter to flow auth v2 #46534

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 15, 2024

In SSO environments with environment variable like kerberos we may not have this authentication type on iOS devices. The current approach to still allow login is to use a direct login with configuring a rewrite on the webserver level:

RewriteEngine on
RewriteCond %{QUERY_STRING} !(?:^|&)direct=[^&]+ [NC]
#RewriteCond %{HTTP_USER_AGENT} (.*)Nextcloud\ iOS(.*)
RewriteCond %{REQUEST_METHOD} =GET
RewriteRule ^/index\.php/login/v2/flow/(.*)$ $0?%{QUERY_STRING}&direct=1 [L,QSA,NC,R=302]
  • Resolves: #

Summary

  • Manually tested using curl and user_saml auth with environment variable
  • Testing with iOS and user_saml auth with environment variable

Checklist

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jul 15, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from a team, ArtificialOwl, icewind1991, yemkareems, ChristophWurst and Altahrim and removed request for a team, ArtificialOwl, icewind1991 and yemkareems August 5, 2024 10:14
@juliusknorr
Copy link
Member Author

/backport to stable29

@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr juliusknorr merged commit 0678bdc into master Aug 5, 2024
169 checks passed
@juliusknorr juliusknorr deleted the fix/direct-flow-v2 branch August 5, 2024 20:05
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Aug 5, 2024
@Altahrim Altahrim mentioned this pull request Aug 6, 2024
@nextcloud nextcloud deleted a comment from backportbot bot Sep 10, 2024
@ChristophWurst
Copy link
Member

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants