Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: Add direct parameter to flow auth v2 #47864

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 10, 2024

Backport of #46534

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@pabzm
Copy link
Contributor

pabzm commented Sep 11, 2024

@ChristophWurst I hope to have fixed it, please have a look.

@ChristophWurst
Copy link
Member

Checked the diff and everything looks great! I'm asking Julius for a second 👀

@juliusknorr juliusknorr marked this pull request as ready for review September 11, 2024 17:17
@pabzm pabzm force-pushed the backport/46534/stable27 branch from 5172020 to cf9d485 Compare September 12, 2024 06:22
@pabzm
Copy link
Contributor

pabzm commented Sep 12, 2024

Can I do something about the CI errors?

@ChristophWurst
Copy link
Member

Not sure why no job ran. You might try with another rebase

@pabzm pabzm force-pushed the backport/46534/stable27 branch from cf9d485 to b381734 Compare September 15, 2024 15:28
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@pabzm pabzm force-pushed the backport/46534/stable27 branch from b381734 to 1f15850 Compare September 17, 2024 18:37
@pabzm
Copy link
Contributor

pabzm commented Sep 18, 2024

I think there's nothing more I can currently do to drive this PR forward? If there is, please let me know.

@susnux
Copy link
Contributor

susnux commented Sep 18, 2024

27 is eol so force merge needed

@juliusknorr juliusknorr merged commit 7d2faa6 into stable27 Sep 18, 2024
38 of 40 checks passed
@juliusknorr juliusknorr deleted the backport/46534/stable27 branch September 18, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants