Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for ExApps to call Admin endpoints marked with specific attr #46607

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Jul 18, 2024

Summary

This is for the Workflow Engine Project, and not only.

The option of duplicating ednpoints where they do not require the admin flag to be set seems to us not quite the right solution; sometimes for ExApps you still need to check whether the user is an administrator or not.

If you need to check the user for ExApp and it works in the user’s context, it sets the userId and everything works as it did.
Only if the request comes from ExApp and the user is not set in the session, then the check for the attributes "AuthorizedAdminSetting" and "SubAdminRequired" is skipped.

Original discussion here: #46539

Important comment: #46539 (review)

Since this opens a wide angle on our APIs, we should make sure that logging (and admin audit logging) is also aware of $this->userSession->getSession()->get('app_api') and properly logs that an action was performed "on behalf of a user" and not "by a user".

But be very careful in the logging so it never fails (catch throwable, etc.) as otherwise logging breaks completely.

This should go in the separate PR a bit later.

Checklist

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit b5ce30d into master Jul 18, 2024
166 checks passed
@bigcat88 bigcat88 deleted the feat/AppApiAdminAccessWithoutUser-attribute branch July 18, 2024 13:19
@blizzz blizzz mentioned this pull request Jul 24, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants