feat: allow for ExApps to call Admin endpoints marked with specific attr #46607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is for the Workflow Engine Project, and not only.
The option of duplicating ednpoints where they do not require the admin flag to be set seems to us not quite the right solution; sometimes for ExApps you still need to check whether the user is an administrator or not.
If you need to check the user for ExApp and it works in the user’s context, it sets the userId and everything works as it did.
Only if the request comes from ExApp and the user is not set in the session, then the check for the attributes "AuthorizedAdminSetting" and "SubAdminRequired" is skipped.
Original discussion here: #46539
Important comment: #46539 (review)
This should go in the separate PR a bit later.
Checklist