Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for ExApps to use webhook_listeners without user context #46615

Merged

Conversation

bigcat88
Copy link
Member

Summary

For the Workflow Engine project, we need to register webhooks from the background job, where we do not have a userId.

This will also be useful in other ExApps in the future.

This special attribute that allows you to do this was added today:

#46607

Checklist

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the app version to make sure the migration step runs. Apart from that: LGTM 👍

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 force-pushed the feat/webhook_listeners-AppApiAdminAccessWithoutUser branch from e15acd6 to 14e07a3 Compare July 18, 2024 15:51
@bigcat88
Copy link
Member Author

You need to change the app version to make sure the migration step runs. Apart from that: LGTM 👍

version changed from 1.0.0-dev to 1.1.0-dev

@julien-nc julien-nc self-requested a review July 18, 2024 16:03
@bigcat88 bigcat88 added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 18, 2024
@bigcat88 bigcat88 merged commit 55dbf39 into master Jul 18, 2024
166 checks passed
@bigcat88 bigcat88 deleted the feat/webhook_listeners-AppApiAdminAccessWithoutUser branch July 18, 2024 17:04
@solracsf solracsf added this to the Nextcloud 30 milestone Jul 20, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants