Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): open-in-files should open a folder and not the parent #46648

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix(files_sharing): open-in-files should open a folder and not the parent #46648

merged 3 commits into from
Jul 25, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 19, 2024

Summary

For files this behavior is fine, but for folders the folder itself should be opened.

Checklist

@susnux susnux requested a review from skjnldsv as a code owner July 19, 2024 17:34
@susnux susnux added this to the Nextcloud 30 milestone Jul 19, 2024
@susnux
Copy link
Contributor Author

susnux commented Jul 19, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jul 19, 2024

/backport to stable28

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2024
@susnux susnux force-pushed the fix/files-sharing-open branch 2 times, most recently from 0a84c7a to 14f6290 Compare July 25, 2024 11:31
@susnux
fix(files_sharing): open-in-files should open a folder and not the …
442a233 
…parent

For files this behavior is fine, but for folders the folder itself should be opened.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: Add regression test for opening shared folders
4979ed0 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
bc216ef 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge July 25, 2024 13:10
@susnux susnux merged commit 9ed6d1e into master Jul 25, 2024
109 checks passed
@susnux susnux deleted the fix/files-sharing-open branch July 25, 2024 13:41
This was referenced Jul 25, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 25, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 31, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

@alperozturk96 alperozturk96 Awaiting requested review from alperozturk96

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Shared Folder Redirecting To Root Directory From "Shared with you" Section
3 participants
@susnux @artonge @skjnldsv