-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] fix(files_sharing): open-in-files
should open a folder and not the parent
#46754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Jul 25, 2024
artonge
approved these changes
Jul 25, 2024
skjnldsv
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Jul 27, 2024
8 tasks
skjnldsv
force-pushed
the
backport/46648/stable28
branch
from
August 2, 2024 07:06
70f5e15
to
381036c
Compare
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
2. developing
Work in progress
labels
Aug 2, 2024
nextcloud-command
force-pushed
the
backport/46648/stable28
branch
from
August 2, 2024 07:16
381036c
to
0fa81f2
Compare
skjnldsv
force-pushed
the
backport/46648/stable28
branch
from
August 2, 2024 07:26
0fa81f2
to
e984059
Compare
/compile rebase-amend / |
nextcloud-command
force-pushed
the
backport/46648/stable28
branch
from
August 2, 2024 07:42
e984059
to
cd4b07d
Compare
skjnldsv
force-pushed
the
backport/46648/stable28
branch
2 times, most recently
from
August 2, 2024 12:39
1a2ae17
to
4467521
Compare
…parent For files this behavior is fine, but for folders the folder itself should be opened. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
backport/46648/stable28
branch
from
August 2, 2024 13:31
4467521
to
9e81a0d
Compare
Too tired, I fixed too many backports already today 😓 |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
backport/46648/stable28
branch
from
August 2, 2024 16:53
9e81a0d
to
fdd1e39
Compare
Caused by an incomplete backport of some other old PR. Fixed it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46648
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.