Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not run SPDX Plugin in dev mode #46903

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

skjnldsv
Copy link
Member

Remove unnecessary step in development mode
Much faster now! 🚀

@skjnldsv skjnldsv requested review from AndyScherzinger, susnux, sorbaugh and a team July 31, 2024 06:54
@skjnldsv skjnldsv self-assigned this Jul 31, 2024
@skjnldsv skjnldsv requested review from nfebe and removed request for a team July 31, 2024 06:54
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/module-webpack-dev branch from 46c9b38 to a04c9e6 Compare July 31, 2024 06:57
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the improvement @skjnldsv 🎉

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jul 31, 2024
@kesselb
Copy link
Contributor

kesselb commented Jul 31, 2024

Thank you very much 👍

I just noticed it the other day, but forgot to log an issue.

@skjnldsv skjnldsv enabled auto-merge July 31, 2024 07:42
@skjnldsv skjnldsv merged commit fcc63ca into master Jul 31, 2024
111 checks passed
@skjnldsv skjnldsv deleted the feat/module-webpack-dev branch July 31, 2024 07:43
@susnux
Copy link
Contributor

susnux commented Jul 31, 2024

Thank you 👍

@blizzz blizzz mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants