Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not run SPDX Plugin in dev mode #46903

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix(build): do not run SPDX Plugin in dev mode #46903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 35 additions & 28 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable n/no-extraneous-require */
/* eslint-disable camelcase */
/**
* SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
Expand All @@ -16,6 +17,7 @@ const WebpackSPDXPlugin = require('./build/WebpackSPDXPlugin.js')
const modules = require('./webpack.modules.js')

const appVersion = readFileSync('./version.php').toString().match(/OC_VersionString[^']+'([^']+)/)?.[1] ?? 'unknown'
const isDev = process.env.NODE_ENV === 'development'

const formatOutputFromModules = (modules) => {
// merge all configs into one object, and use AppID to generate the fileNames
Expand Down Expand Up @@ -48,7 +50,7 @@ const modulesToBuild = () => {
return formatOutputFromModules(modules)
}

module.exports = {
const config = {
entry: modulesToBuild(),
output: {
// Step away from the src folder and extract to the js folder
Expand Down Expand Up @@ -149,23 +151,6 @@ module.exports = {
},

optimization: {
minimizer: [{
apply: (compiler) => {
// Lazy load the Terser plugin
const TerserPlugin = require('terser-webpack-plugin')
new TerserPlugin({
extractComments: false,
terserOptions: {
format: {
comments: false,
},
compress: {
passes: 2,
},
},
}).apply(compiler)
},
}],
splitChunks: {
automaticNameDelimiter: '-',
minChunks: 3, // minimum number of chunks that must share the module
Expand Down Expand Up @@ -238,16 +223,6 @@ module.exports = {
resourceRegExp: /^\.\/locale$/,
contextRegExp: /moment\/min$/,
}),

// Generate reuse license files
new WebpackSPDXPlugin({
override: {
select2: 'MIT',
'@nextcloud/axios': 'GPL-3.0-or-later',
'@nextcloud/vue': 'AGPL-3.0-or-later',
'nextcloud-vue-collections': 'AGPL-3.0-or-later',
}
}),
],
externals: {
OC: 'OC',
Expand All @@ -274,3 +249,35 @@ module.exports = {
},
},
}

// Generate reuse license files if not in development mode
if (!isDev) {
config.plugins.push(new WebpackSPDXPlugin({
override: {
select2: 'MIT',
'@nextcloud/axios': 'GPL-3.0-or-later',
'@nextcloud/vue': 'AGPL-3.0-or-later',
'nextcloud-vue-collections': 'AGPL-3.0-or-later',
},
}))

config.optimization.minimizer = [{
apply: (compiler) => {
// Lazy load the Terser plugin
const TerserPlugin = require('terser-webpack-plugin')
new TerserPlugin({
extractComments: false,
terserOptions: {
format: {
comments: false,
},
compress: {
passes: 2,
},
},
}).apply(compiler)
},
}]
}

module.exports = config
Loading