Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin_audit): Do not log errors for new files #47071

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 6, 2024

Avoid logging an error for cases when the audit log is triggered on a new file during the BeforeNodeReadEvent as in this case we get an NonExistingFile as the file has no file id yet

Sample error trace:

Screenshot 2024-08-06 at 14 54 11

Checklist

@juliusknorr juliusknorr force-pushed the fix/no-error-new-file-audit branch from 7f5da07 to a56f5d4 Compare August 6, 2024 12:52
@juliusknorr juliusknorr requested review from yemkareems, artonge, a team and icewind1991 and removed request for a team August 6, 2024 12:55
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Aug 6, 2024
@AndyScherzinger AndyScherzinger force-pushed the fix/no-error-new-file-audit branch from a56f5d4 to 367c36a Compare August 6, 2024 18:07
@AndyScherzinger AndyScherzinger force-pushed the fix/no-error-new-file-audit branch from 367c36a to 0b399d2 Compare August 7, 2024 07:38
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/no-error-new-file-audit branch from 0b399d2 to 1c0f02e Compare August 7, 2024 07:50
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
@AndyScherzinger AndyScherzinger merged commit 0050e1e into master Aug 7, 2024
169 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/no-error-new-file-audit branch August 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants