-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Access node owner by top level owner
property
#47287
Conversation
/backport to stable30 |
@@ -69,7 +67,7 @@ export const action = new FileAction({ | |||
} | |||
|
|||
// Group shares | |||
if (shareTypes.includes(ShareType.Grup) | |||
if (shareTypes.includes(ShareType.Group) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good one 😅🙈
|
Happens because Cypress does not compile the sources before testing -> So it fails like it does on master. As soon as we compile it will work here. (No idea why the compile step was removed from cypress?) |
aeb6317
to
eb89925
Compare
/compile |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
d26e288
to
fa11a67
Compare
Summary
As suggested by @skjnldsv in the previous PR we should not use
owner-id
directly but just use the top levelowner
attribute (which will be set to owner-id anyways by default).This fixes the mentioned issue, moreover I added some tests for the inline status action and a regression test for this bug.
(We nevertheless should fix the wrong type of the
owner-id
attribute indavResultToNode
and cast it to string, but we can do so later in@nextcloud/files
)Checklist