Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] Fix file item display for users with numerical user IDs #48417

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Sep 27, 2024

This is a partial backport of #47287 . I'm not sure it's enough and not sure about the "sharee" part in the title function.
Maybe a full backport would be better than this. Wdyt?

I first saw the issue in 29.0.7 (files displayed as shared by their owner if the user ID is numerical) and checked if it was different in stable29. The issue was still there but not really visible because of the isExternal check that was wrong.

To reproduce the issue:

  • Checkout stable29
  • Create a user (database backend works) with a numerical ID (like 123456789)
  • Browse the Files app
  • See JS errors like
    image

Check the fix:

  • Checkout this branch
  • Compile the server assets
  • There should be no more error when browsing the files app with the 123456789 user

@julien-nc julien-nc added this to the Nextcloud 29.0.8 milestone Sep 27, 2024
@julien-nc julien-nc requested review from susnux, skjnldsv, a team and nfebe and removed request for a team September 27, 2024 10:02
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, but did not test.
I agree a full backport would make sense, but the sharee title stuff should not be related to the issue (just another issue^^).

…merical user ID

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the fix/stable29/numerical-userid-file-item-display branch from 49394cb to 0af3637 Compare September 30, 2024 08:23
@julien-nc julien-nc requested a review from kyteinsky September 30, 2024 08:49
@julien-nc
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@julien-nc julien-nc merged commit 74a5eaf into stable29 Sep 30, 2024
110 checks passed
@julien-nc julien-nc deleted the fix/stable29/numerical-userid-file-item-display branch September 30, 2024 09:44
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants