fix(a11y): Update OpenDyslexic from 0.920 to 2.001 #47928
Conversation
nickvergessen
added
3. to review
| @@ -43,30 +43,22 @@ public function getCSSVariables(): array { | |||
| } | |||
|
|
|||
| public function getCustomCss(): string { | |||
| $fontPathWoff = $this->urlGenerator->linkTo('theming', 'fonts/OpenDyslexic-Regular.woff'); | |||
There was a problem hiding this comment.
otf is supported by all supported browsers (IE was the last one), so we can drop the others
There was a problem hiding this comment.
Beside browser support, WOFF is generaly more lightweight too.
There was a problem hiding this comment.
But WOFF is not provided by the creator and I don't know what happens with licenses when using a convertor of any kind ¯\_(ツ)_/¯ The files are ~41KB and ~42KB. I really don't care too much about such a little size to risk license issues
There was a problem hiding this comment.
That being said, the old font file was ~250KB and the WOFF was ~120KB there it made a bit more sense
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/update-opendyslexic
branch
from
c8cdb74
to
599a94f
Compare
There was a problem hiding this comment.
Wow, amazing improvement! FYI @xBelladonna if you want to check it out. :)
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
I think this should be backported |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable30 |
Summary
Checklist