fix(a11y): Add OTF font loading check #48063
Merged
+25
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
|
/backport to stable30 |
2 tasks
|
4 tasks
kesselb
approved these changes
Sep 16, 2024
skjnldsv
approved these changes
Sep 16, 2024
|
Would it make sense to compress to WOFF2 or do we not care about the filesize? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I applied #47995 on production and the font didn't work anymore. Turns out OTF file loading is not checked and not allowed by .htaccess in default.
Since the check only exists since Nextcloud 29 I will cancel the backport of the dyslexia for 28 as we can not easily adjust the check there.
Checklist