[stable28] Ci fixes #48213
Open
[stable28] Ci fixes #48213
+268
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
artonge,
come-nc,
skjnldsv and
icewind1991
backportbot
bot
added
bug
3. to review
Signed-off-by: Louis Chemineau <louis@chmn.me>
…FromStorage Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…utput Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
icewind1991
force-pushed
the
backport/48205/stable28
branch
from
c18d146
to
c255e70
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!($trashStorage->instanceOfStorage(ObjectStoreStorage::class) && $trashStorage->getId() === $sourceStorage->getId())) { | ||
| $trashStorage->moveFromStorage($sourceStorage, $sourceInternalPath, $trashInternalPath); | ||
| } | ||
| if ($trashStorage->getCache()->inCache($sourceInternalPath)) { |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable Note
| if (!($trashStorage->instanceOfStorage(ObjectStoreStorage::class) && $trashStorage->getId() === $sourceStorage->getId())) { | ||
| $trashStorage->moveFromStorage($sourceStorage, $sourceInternalPath, $trashInternalPath); | ||
| } | ||
| if ($trashStorage->getCache()->inCache($sourceInternalPath)) { | ||
| $trashStorage->getUpdater()->renameFromStorage($sourceStorage, $sourceInternalPath, $trashInternalPath); |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable Note
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
backport/48205/stable28
branch
from
0fdf940
to
2777947
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
This was referenced Sep 20, 2024
artonge
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48205
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.