test: re-add object store primary storage phpunit tests #48235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
readd-object-store-phpunit
branch
6 times, most recently
from
d22b132
to
15f5266
Compare
icewind1991
requested review from
a team,
Altahrim,
nfebe and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Sep 27, 2024
susnux
reviewed
Sep 27, 2024
| @@ -0,0 +1,121 @@ | |||
| # SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | |||
| # SPDX-License-Identifier: MIT | |||
| name: PHPUnit primary object store | |||
There was a problem hiding this comment.
This is what object-storage-s3.yml should do so I would not add a new one but just enable more tests there then.
There was a problem hiding this comment.
The object-storage-* tests test the implementation of the object store. This tests how the/any object store integrates with the rest of the system
There was a problem hiding this comment.
So this is more of an integration test?
But what I meant is why not just add this as a step to the other workflow. Then one would only need to configure all services once and less work if something changes.
Signed-off-by: Robin Appelman <robin@icewind.nl>
…store otherwise this causes confusion down the line as it's contents will be moved to the new cache Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
readd-object-store-phpunit
branch
from
e37cfa2
to
3e12e1e
Compare
|
/backport to stable29 |
2 tasks
|
backport for 28 has been merged into #48213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed with #41003 but the object store related tests that were migrated there are not equivalent.