fix(ShareAPI): Send mails for mail shares by default #48381
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
added
3. to review
Fenn-CS
force-pushed
the
fix/48012/fix-share-email-send-mail-share
branch
from
33e46ad
to
6553268
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
provokateurin
approved these changes
Sep 26, 2024
Fenn-CS
force-pushed
the
fix/48012/fix-share-email-send-mail-share
branch
from
6553268
to
8103393
Compare
|
/backport to stable30 |
Fenn-CS
force-pushed
the
fix/48012/fix-share-email-send-mail-share
branch
from
8103393
to
410854f
Compare
come-nc
approved these changes
Sep 26, 2024
Fenn-CS
force-pushed
the
fix/48012/fix-share-email-send-mail-share
branch
from
410854f
to
3f7528b
Compare
Fenn-CS
force-pushed
the
fix/48012/fix-share-email-send-mail-share
branch
2 times, most recently
from
da2d0c3
to
e2fa7e1
Compare
It looks like, the frontend it needs to provide the `sendMail` param for the backend to decide wether mails would be sent. Our UI does not have that at the moment so it should default to sending emails always for mail shares. Not exactly sure how this was handled earlier but this is a good starting point. Resolves : #48012 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
fix/48012/fix-share-email-send-mail-share
branch
from
e2fa7e1
to
9f0eda3
Compare
|
Why rebase it so often? |
Some tests that seem unrelated (cypress especially are failing consistently)... Re-basing triggers a rerun, but also adds the latest updates on master in case something that broke the tests has been resolved. (Because a bunch of other PRs are failing tests too)... Now taking a closer to see if something is indeed broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like, the frontend it needs to provide the
sendMailparam for the backend to decide whether mails would be sent.Our UI does not have that at the moment so it should default to sending emails always for mail shares.
Not exactly sure how this was handled earlier but this is a good starting point.
Resolves : #48012
Checklist