-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple Admin UI to manage systemtags #494
Conversation
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81 and @LukasReschke to be potential reviewers |
'systemtags/systemtagscollection', | ||
]); | ||
|
||
script('systemtags_manager', 'admin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appid should be systemtags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
the ui seems very clunky and different to most other ui's we have for similar things. imo having a list with all tags that allow inline editing would be a lot nices (it would also probably make sense to have it in a seperate page/app entirely so the ui gets plenty of space) |
That list might be too long
The problem is the tags are delivered via webdav, so I was happy that it was already managed with backbone. I'd go with this simple approach for now (10), and we can still change it and come up with a better UI later on. |
14cf786
to
ca4c785
Compare
Maybe we could solve that via #267 ... How did we do that in EE Workflow? @icewind1991 |
@Mar1u5 similar to the current solution |
a595c95
to
5bb3557
Compare
Rebased, please review |
It's really rough from an UX point of view. But it works. Maybe we can sit together next week and refine the UI. 👍 from me |
👍 |
@nickvergessen Mind opening a backport to 10? :) |
Backport in #619 |
ToDo:
Ref 1. part of #231
@Mar1u5 in case you want to help testing