Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple Admin UI to manage systemtags #494

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

nickvergessen
Copy link
Member

ToDo:

  • API seems to support groups (?), maybe something for later/second PR

Ref 1. part of #231

@Mar1u5 in case you want to help testing

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81 and @LukasReschke to be potential reviewers

'systemtags/systemtagscollection',
]);

script('systemtags_manager', 'admin');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appid should be systemtags

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@icewind1991
Copy link
Member

the ui seems very clunky and different to most other ui's we have for similar things.

imo having a list with all tags that allow inline editing would be a lot nices

(it would also probably make sense to have it in a seperate page/app entirely so the ui gets plenty of space)

@nickvergessen
Copy link
Member Author

imo having a list with all tags that allow inline editing would be a lot nices

That list might be too long

it would also probably make sense to have it in a seperate page/app entirely so the ui gets plenty of space

The problem is the tags are delivered via webdav, so I was happy that it was already managed with backbone. I'd go with this simple approach for now (10), and we can still change it and come up with a better UI later on.

@nickvergessen nickvergessen added this to the Nextcloud Next milestone Jul 21, 2016
@nickvergessen nickvergessen force-pushed the systemtag-management branch from 14cf786 to ca4c785 Compare July 21, 2016 13:46
@MorrisJobke MorrisJobke modified the milestones: Nextcloud Next, Nextcloud 10.0 Jul 21, 2016
@MariusBluem
Copy link
Member

(it would also probably make sense to have it in a seperate page/app entirely so the ui gets plenty of space)

Maybe we could solve that via #267 ... How did we do that in EE Workflow? @icewind1991

@nickvergessen
Copy link
Member Author

How did we do that in EE Workflow?

@Mar1u5 similar to the current solution

@nickvergessen nickvergessen force-pushed the systemtag-management branch from a595c95 to 5bb3557 Compare July 27, 2016 13:29
@nickvergessen
Copy link
Member Author

Rebased, please review

@MorrisJobke
Copy link
Member

It's really rough from an UX point of view. But it works. Maybe we can sit together next week and refine the UI.

👍 from me

@LukasReschke
Copy link
Member

👍

@LukasReschke LukasReschke merged commit abdf8c2 into master Jul 28, 2016
@LukasReschke LukasReschke deleted the systemtag-management branch July 28, 2016 07:36
@LukasReschke
Copy link
Member

@nickvergessen Mind opening a backport to 10? :)

@nickvergessen
Copy link
Member Author

Backport in #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants