Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only apply bullet style to ul > li #2186

Merged
merged 1 commit into from
Feb 21, 2022
Merged

fix: only apply bullet style to ul > li #2186

merged 1 commit into from
Feb 21, 2022

Conversation

max-nextcloud
Copy link
Collaborator

  • Make list items in ordered lists still show numbers.
  • Use the same bullets on second and third level when first level is ol.

Signed-off-by: Max max@nextcloud.com

@max-nextcloud max-nextcloud requested review from jancborchardt, a team, azul and mejo- and removed request for a team February 17, 2022 09:59
@max-nextcloud
Copy link
Collaborator Author

/backport to stable23

@max-nextcloud
Copy link
Collaborator Author

/backport to stable22

@max-nextcloud
Copy link
Collaborator Author

/backport to stable21

juliushaertl
juliushaertl approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Restarted cypress as failures seemed unrelated.

@max-nextcloud
fix: only apply bullet style to ul > li
87b658a 
* Make list items in ordered lists still show numbers.
* Use the same bullets on second and third level when first level is ol.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud merged commit 12c0684 into master Feb 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/2185-nested-ol branch February 21, 2022 14:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 21, 2022
Merged
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

This was referenced Feb 22, 2022
Merged
Merged
@juliushaertl juliushaertl added bug Something isn't working and removed backport-request labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@azul azul Awaiting requested review from azul azul was automatically assigned from nextcloud/office

@mejo- mejo- Awaiting requested review from mejo- mejo- was automatically assigned from nextcloud/office

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ordered lists nested in unordered lists do not show numbers
2 participants
@max-nextcloud @juliushaertl