Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] fix: only apply bullet style to ul > li #2195

Merged
merged 1 commit into from
Mar 1, 2022
Merged

[stable23] fix: only apply bullet style to ul > li #2195

merged 1 commit into from
Mar 1, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 21, 2022 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #2186

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.3 milestone Feb 21, 2022
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Feb 23, 2022
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Feb 26, 2022 •
edited
Loading

I tried to reproduce this locally but got very different psalm errors.
I think the error is related to nextcloud/server@003f2b5
but i don't know enough about psalm to fix it. My guess would have been something like psalm update baseline or so to acknowledge the issue - but that seems odd when seeing other errors locally.

@azul azul removed their request for review February 26, 2022 18:28
@max-nextcloud
Copy link
Collaborator

/rebase

@max-nextcloud
Copy link
Collaborator

/compile amend /

@max-nextcloud @nextcloud-command
fix: only apply bullet style to ul > li
8889328 
* Make list items in ordered lists still show numbers.
* Use the same bullets on second and third level when first level is ol.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud merged commit adc6c29 into stable23 Mar 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/2186/stable23 branch March 1, 2022 11:32
@blizzz blizzz mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@mejo- mejo- Awaiting requested review from mejo-

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 23.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@max-nextcloud @juliushaertl