Bring back keyboard shortcuts to help modal on non-mobile #4251
Conversation
|
/backport to stable27 |
|
/backport to stable26 |
1 flaky tests on run #10272 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves the actual file and document state |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
| @@ -180,7 +180,7 @@ | |||
|
|
|||
| <script> | |||
| import { NcModal, Tooltip } from '@nextcloud/vue' | |||
| import { isMobilePlatform } from './../helpers/platform.js' | |||
There was a problem hiding this comment.
Any insight why isMobilePlatform doesn't work? From looking at the code the checks in there seem more sane then the plain screen size check if isMobile
There was a problem hiding this comment.
Well, the problem here was that isMobilePlatform is a method, not a computed property. After changing the v-if statements to !isMobilePlatform() it worked as well. Updated the PR accordingly now.
I also went with caching the result of method isMobilePlatform() as computed property, given that it doesn't change within one browser anyway.
mejo-
force-pushed
the
fix/fix_help_hotkeys
branch
from
e4a6e16
to
e191e65
Compare
|
/compile |
Cache result of method `isMobilePlatform()` as computed property, given that it doesn't change within one browser anyway. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/fix_help_hotkeys
branch
from
8175102
to
292f438
Compare
|
/compile amend |
Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/fix_help_hotkeys
branch
from
292f438
to
26cfdf6
Compare
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport 5149309,4dae22a6fcea13cb25ee997335fdcf5005373f42 to stable27 |
|
/backport 5149309,4dae22a6fcea13cb25ee997335fdcf5005373f42 to stable26 |
No description provided.