Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Bring back keyboard shortcuts to help modal on non-mobile #4319

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #4251

@cypress
Copy link

cypress bot commented Jun 20, 2023

2 flaky tests on run #10426 ↗︎

0 146 1 0 Flakiness 2

Details:

[stable26] Bring back keyboard shortcuts to help modal on non-mobile
Project: Text Commit: 70734f2967
Status: Passed Duration: 03:08 💡
Started: Jun 22, 2023 9:00 PM Ended: Jun 22, 2023 9:03 PM
Flakiness  nodes/HardBreak.spec.js • 1 flaky test

View Output Video

Test Artifacts
Hard break support > Can create hard breaks with shift+enter Output Screenshots
Flakiness  files.spec.js • 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle plaintext in a pre tag Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Cache result of method `isMobilePlatform()` as computed property, given
that it doesn't change within one browser anyway.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit 5db88ed into stable26 Jun 22, 2023
32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/4251/stable26 branch June 22, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants