Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix(editor): Don't load both Tiptap collaboration history extensions #4623

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #4621

Instead of loading Tiptap `extension-history` in RichText.js, let's load
it only in `MarkdownContentEditor.vue`.

* Editor.vue loads `extension-collaboration`
* MarkdownContentEditor.vue loads `extension-history`

Fixes: #4601

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member

mejo- commented Aug 2, 2023

/compile

@cypress
Copy link

cypress bot commented Aug 2, 2023

2 flaky tests on run #11473 ↗︎

0 148 2 0 Flakiness 2

Details:

[stable26] fix(editor): Don't load both Tiptap collaboration history extensions
Project: Text Commit: ec3311e382
Status: Passed Duration: 04:25 💡
Started: Aug 2, 2023 3:30 PM Ended: Aug 2, 2023 3:35 PM
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots
Flakiness  api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit ba5798e into stable26 Aug 2, 2023
32 checks passed
@mejo- mejo- deleted the backport/4621/stable26 branch August 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants