fix: Only remove openfile from route when closing the viewer #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
artonge
force-pushed
the
artonge/fix/only_remove_openfile
branch
from
d3143de
to
ecaff7e
Compare
susnux
approved these changes
Sep 13, 2024
skjnldsv
approved these changes
Sep 13, 2024
If the route has changed between when the Viewer was opened and then closed, then the 'old' route will be restored. But probably want to keep it and only remove the `openfile` query. Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/only_remove_openfile
branch
from
ecaff7e
to
a4143a9
Compare
|
/compile rebase / |
|
/backport a4143a9 to stable30 |
|
/backport a4143a9 to stable29 |
|
/backport a4143a9 to stable28 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/2493/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4143a9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2493/stable28Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/2493/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4143a9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2493/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2493/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4143a9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2493/stable30Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
hmmmm |
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the route has changed between when the Viewer was opened and then closed, then the 'old' route will be restored. But we probably want to keep the current route and only remove the
openfilequery.More specifically, the fileid is removed from the route if it was not in the route when the Viewer was opened.
Can be triggered by changing the view and opening a file. Somehow not triggered every time.
On load, the viewer is somehow triggered twice, a first time with
fileid = undefined, and a second time withfileid = an actual file ID. So the bug is not really visible.Here, it is visible on the third attempt to close the Viewer:
Screencast.from.2024-09-12.15-41-14.mp4
Found this while working on nextcloud/server#47920