Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: Only remove openfile from route when closing the viewer #2539

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 16, 2024

Manual backport of #2493

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Sep 16, 2024
@artonge artonge added this to the Nextcloud 29.0.7 milestone Sep 16, 2024
@artonge artonge requested review from susnux and skjnldsv September 16, 2024 12:43
@artonge artonge self-assigned this Sep 16, 2024
@artonge artonge changed the title fix: Only remove openfile from route when closing the viewer [stable29] fix: Only remove openfile from route when closing the viewer Sep 16, 2024
@artonge
Copy link
Contributor Author

artonge commented Sep 16, 2024

/backport! a10a3e1 to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 16, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Sep 16, 2024
@artonge artonge enabled auto-merge September 16, 2024 12:45
@artonge
Copy link
Contributor Author

artonge commented Sep 16, 2024

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv disabled auto-merge September 20, 2024 10:28
@skjnldsv skjnldsv merged commit e39a90a into stable29 Sep 20, 2024
28 of 31 checks passed
@skjnldsv skjnldsv deleted the artonge/backport/stable29/2493 branch September 20, 2024 10:30
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants