Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage files to tmp files, then atomically move #1713

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

jchorl
Copy link
Contributor

@jchorl jchorl commented Aug 19, 2020

Fixes #1552

The comments should explain it. I tested locally.

Signed-off-by: Josh Chorlton <jchorlton@gmail.com>
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! please have a look at my comment.

Signed-off-by: Josh Chorlton <jchorlton@gmail.com>
@jchorl
Copy link
Contributor Author

jchorl commented Aug 21, 2020

PTAL @pditommaso

@pditommaso pditommaso merged commit 6ddf0d8 into nextflow-io:master Aug 21, 2020
@pditommaso
Copy link
Member

Thanks for contributing to the project!

@pditommaso
Copy link
Member

and obviously the devil hides in the details! Fails using S3 :/

Aug-21 11:10:11.055 [Actor Thread 9] ERROR nextflow.processor.TaskProcessor - Error executing process > 'MULTIQC'

Caused by:
  java.lang.UnsupportedOperationException

java.lang.UnsupportedOperationException: null
	at com.upplication.s3fs.S3FileSystemProvider.move(S3FileSystemProvider.java:558)
	at nextflow.file.FileHelper.movePath(FileHelper.groovy:846)
	at nextflow.file.FilePorter$FileTransfer.stageForeignFile0(FilePorter.groovy:297)
	at nextflow.file.FilePorter$FileTransfer.stageForeignFile(FilePorter.groovy:258)
	at nextflow.file.FilePorter$FileTransfer.run(FilePorter.groovy:244)

pditommaso added a commit that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forcing interruption of pipeline makes staged files not to be re-downloaded
2 participants