Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shell directive with trace command in wrapper script #4292

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

bentsherman
Copy link
Member

Close #4209

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 6e914aa
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/64ff28e941f013000773c31a

@rollf
Copy link

rollf commented Jan 17, 2025

@bentsherman Could this PR be updated and merged? (Asking for a friend.)

@pditommaso
Copy link
Member

This is a -1 for me because it's changing the flag used to run the trace script adding -eu. While this seems innocuous and even better, it can introduce subtle different behaviour hard to predict and above all to tests.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 51bb35c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/678a3c8eaab76d0008f71ebb

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member

This 392073b should achieve the same without changing the default behaviour

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@bentsherman
Copy link
Member Author

Makes sense to me

@pditommaso pditommaso merged commit 8342889 into master Jan 17, 2025
9 checks passed
@pditommaso pditommaso deleted the 4209-nxf-trace-with-shell branch January 17, 2025 13:19
@sstrong99
Copy link

what is a good way to track when this change is released?

@bentsherman
Copy link
Member Author

Edge release should be coming out in the next week or two. You can probably subscribe to release notifications? You can also check the merge commit and it will tell you which releases have the commit.

@pditommaso
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using tracing invalidates use of shell directive
4 participants