-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all processes in inspect command #5580
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesss! 🙏🏻
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
modules/nextflow/src/main/groovy/nextflow/script/ScriptRunner.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! made a couple of minor comments
modules/nextflow/src/main/groovy/nextflow/script/ScriptRunner.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/script/ProcessDef.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Ok, thinks we are there. Pushed a few changes
|
Vamos! |
// setting module true when running in "inspect" mode to prevent the running the entry workflow | ||
.setModule(ContainerInspectMode.active()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will still run the entry workflow if concretize
is enabled, is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, initially I was thinking the run was needed by the contretize to await for the container completion, but checking it now it implemented here.
therefore the "breaking" change is needed the ContainerInspectMode
class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a way to improve the
inspect
command without using the new script parser -- I just look at all process definitions across all included scripts, regardless of whether they are ever called.All processes are included, even if a process is defined but never called by the workflow. Static analysis would be required to extract the process calls from the workflow.
The process "base name" is used instead of the fully qualified name, and aliases are not included. Static analysis would be required to get the fully qualified name. But I figured the base name is fine because you shouldn't need to specify different containers for different instances of the same process.
I went ahead with this approach because nf-core needs this functionality and I don't know how long it will take to incorporate the new script parser.
Here's the output for rnaseq: