Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auspice JSON colorings for HA/NA accessions #138

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Dec 28, 2023

Description of proposed changes

Adds coloring entries for the HA and NA accessions associated with each sequence in a build, so this information appears in the public trees and allows users to determine the sequences that correspond with each strain name.

Related issue(s)

Closes #137

Checklist

  • Checks pass

Adds coloring entries for the HA and NA accessions associated with each
sequence in a build, so this information appears in the public trees and
allows users to determine the sequences that correspond with each strain
name.

Closes #137
@huddlej huddlej requested a review from j23414 December 28, 2023 19:17
@j23414
Copy link
Contributor

j23414 commented Dec 28, 2023

Copy link
Contributor

@j23414 j23414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test run succeeded, and I see that the accessions are being included as expected in the downloaded Nexus file (and not in the nwk file).

[non-blocking] I slightly lean towards having these in the "acknowledgements.tsv" file, but I imagine that using Nexus might be the fastest solution for now. Just a note that there is a slight pause in the site if the user selects "Color By: accession..." from the drop down, but I hope this occurrence will be infrequent and non-blocking.

@huddlej
Copy link
Contributor Author

huddlej commented Dec 28, 2023

Thanks, @j23414! The implementation as a coloring is not ideal, but hopefully this will be useful for people and we'll eventually setup an augur/auspice interface that doesn't require these to be colorings.

@huddlej huddlej merged commit b91fbe2 into master Dec 28, 2023
5 checks passed
@huddlej huddlej deleted the export-accession branch December 28, 2023 22:43
joverlee521 added a commit that referenced this pull request Sep 10, 2024
Following up on @huddlej's comment
<#138 (comment)>

Instead of using the accessions as colorings to force their inclusion
in the build, just include them as `metadata_columns`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export GISAID accessions from metadata into Auspice JSONs
2 participants