Integrate arkworks patch for deserializing group elements #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's merged already, though tests are failing on the CI |
slumber
reviewed
Feb 23, 2024
Comment on lines
-40
to
+42
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| lfs: 'true' |
There was a problem hiding this comment.
This change should be dropped at least for main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the arkworks-algebra dependencies up to PR 771. This patch is based on the most recent version, and introduces a few changes that are unrelated to PR 771. We should wait until arkworks merges the PR and update the Cargo dependency to the main branch before merging this.