faster is_in_correct_subgroup_assuming_on_curve
when cofactor is one
#771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a two-line fix to speed up the function
is_in_correct_subgroup_assuming_on_curve
for short Weierstrass curve points:if the cofactor is one, it skips the expensive operation of performing a scalar multiplication by the scalar field's characteristic.
The cofactor is always one when the curve forms part of a cycle, so this is relevant for the curves used for most
recursive SNARKs (e.g.
bn254
, etc.).This speeds up operations like
CanonicalDeserialize::deserialize_compressed
, which can otherwise take a verylong time for large vectors of curve points. It should also reduce the number of constraints needed to allocate
a curve variable.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer